afsc-assessments / afscdata

An R package for data extraction of AFSC survey and fishery data
https://afsc-assessments.github.io/afscdata/
Other
2 stars 0 forks source link

doesn't match #37

Closed pete-hulson closed 1 month ago

pete-hulson commented 1 year ago

https://github.com/afsc-assessments/afscdata/blob/b36ad961f895d55187889cf810fc5efcef74feb4/R/queries.R#L287 this table doesn't match the goa.agecomp_total, which is what we've always pulled from, can we switch this table to agecomp_total with paste0(region, '.AGECOMP_TOTAL'), would also need to change the sizecomp one to paste0(region, '.SIZECOMP_TOTAL')

BenWilliams-NOAA commented 1 year ago

See #2 in appendix B https://docs.google.com/document/d/1ie0it6G_V_PrpO1fYe-731Fvubuahn2yi0ixBIpaYO8/edit

gap_products is where everything is moving to. possibly best to make the leap sooner rather than later?

pete-hulson commented 1 year ago

sounds good to me