search

afsc-assessments / afscdata

An R package for data extraction of AFSC survey and fishery data
https://afsc-assessments.github.io/afscdata/
Other
2 stars 0 forks source link

location for ss3 items #46

Open BenWilliams-NOAA opened 9 months ago

BenWilliams-NOAA commented 9 months ago

https://github.com/afsc-assessments/afscdata/blob/54852bea4dae5a404b7559854a9cc3c37b7075d7/R/utils.R#L222

@mkapur-noaa I'm leaning toward this type of function not being in afscdata, but placing it in afscassess. Couple of reasons:

  1. The data query function should produce the same data for every assessment, if this gets implemented at the start then data format will start off different between different assessments,
  2. There is a clean_catch function in afscassess, I think having a clean_catch_ss function or age_comp_ss, etc. would be a method for maintaining consistent code structures Thoughts?

Edit: looking at this function further, I would strongly suggest not using this method to include/not include the proj catch data that produces the same output file name - it seems to inevitably get messed up in the plotting/report arenas

mkapur-noaa commented 9 months ago

I'm OK with this approach; I think I opted for it since I wasn't loving maintenance/pushes to two separate packages. I know @careymcgilliard had talked about sitting down to develop generalized SS3 munging scripts but not sure where she is at with respect to this package vs gapindex (vs overall bandwidth).

In any case, I don't plan on adding any further SS3-style scripts to this package. So, if you feel strongly about migrating it to afscassess just let me know.