search

afsc-assessments / afscdata

An R package for data extraction of AFSC survey and fishery data
https://afsc-assessments.github.io/afscdata/
Other
2 stars 0 forks source link

Same as previous, lowercase area/ region name when saving file #52

Closed KristenOmori-NOAA closed 1 month ago

KristenOmori-NOAA commented 2 months ago

https://github.com/afsc-assessments/afscdata/blob/3f41c2c1b714b1f3ad4bde019c0f18c743cce5d5/R/queries.R#L121

Same as with the bts length data... to make the raw data query compatible with the afscasssess, can you make the file output area name to lowercase?

BenWilliams-NOAA commented 2 months ago

i'll adjust, but should all work if enter the area as lowercase to start with

KristenOmori-NOAA commented 2 months ago

Actually, can you change to goa_bts_length_specimen_data.csv

KristenOmori-NOAA commented 2 months ago

the area name gets changed to upper case in the "global" section of that function.

BenWilliams-NOAA commented 2 months ago

nah it changes to ar = toupper(area)

BenWilliams-NOAA commented 2 months ago

Actually, can you change to goa_bts_length_specimen_data.csv

I'm gonna recommend against this - mostly for historical reasons. The specimen data has always been associated with age information/samples so combining these would increase the likelihood of downstream confusion

KristenOmori-NOAA commented 2 months ago

That's fine, would you be able to change the file name to match what goes into the afscassess::bts_length_comp data file then?

BenWilliams-NOAA commented 1 month ago

pretty sure this was fixed?

KristenOmori-NOAA commented 1 month ago

yeah... the query outputs are all linked to the appropriate data formatting functions.