afsc-assessments / spmR

Projection model for evaluating outcomes of catch control rules for Alaska groundfish
http://afsc-assessments.github.io/spmR/
2 stars 1 forks source link

Request to add new output file for SAFE exec table #3

Open Cole-Monnahan-NOAA opened 2 years ago

Cole-Monnahan-NOAA commented 2 years ago

I'd like to see a single, simple file produced that contains the information needed in the executive table in the SAFEs. Something that would be easy to open in Excel or transfer to a markdown format. I know some people use complicated R functions to read and parse the output files, and some people open them manually and copy/paste into Excel.

I think doing it inside proj has several advantages. Off the top of my head (1) less work for analysts during crunch time; (2) less chance of copy paste errors or grabbing the wrong value.

@jimianelli-NOAA Is this feasible? I know there's a lot of other stuff proj does that could interfere with something like this. @mkapur-noaa also showed an interest in this. We could help develop and/or test it.

mkapur-noaa commented 2 years ago

Yes, I would give this a +1. IIRC, we have a postdoc (Mathieu?) who is working to update Proj into TMB, and I imagine he could automate some of the output materials via REPORT (or post-hoc within R). Definitely agree that reading and parsing the .txt file that comes out of Proj currently can lead to transcription errors (happened to me this cycle!). MK

On Wed, Dec 8, 2021 at 4:59 PM Cole Monnahan @.***> wrote:

I'd like to see a single, simple file produced that contains the information needed in the executive table in the SAFEs. Something that would be easy to open in Excel or transfer to a markdown format. I know some people use complicated R functions to read and parse the output files, and some people open them manually and copy/paste into Excel.

I think doing it inside proj has several advantages. Off the top of my head (1) less work for analysts during crunch time; (2) less chance of copy paste errors or grabbing the wrong value.

@jimianelli-NOAA https://github.com/jimianelli-NOAA Is this feasible? I know there's a lot of other stuff proj does that could interfere with something like this. @mkapur-noaa https://github.com/mkapur-noaa also showed an interest in this. We could help develop and/or test it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/afsc-assessments/AK-projection-simulation/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJMO6DTCD5CU65BI7T3RM3DUP75OXANCNFSM5JVE53EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jimianelli commented 2 years ago

sorry for delays in responding to this, I agree but there are a couple of issues:

  1. The ABCs and OFLs that get enacted may differ from recommendations (it's not a simple copy from previous year's assessment necessarily)
  2. I've made a repo now for Plan Team and author's purposes that has all the historical ABCs and OFLs that have appeared in the Federal Register, linking that in would be a good approach; also would be useful for making/updating the tables of TACs, OFLs, ABCs (but doesn't have official total catches) https://github.com/afsc-assessments/gf_specs
  3. The https://github.com/afsc-assessments/sara could also be useful, or be part of the post-assessment process.
Cole-Monnahan-NOAA commented 2 years ago

I'm only talking about the two columns from this year's proj output, not the previous. I feel like the latter is a different question. I maintain that chasing down individual components of the table from different proj output files is ripe for copy/paste or mistakes.

jimianelli-NOAA commented 2 years ago

yea, I did put Tier_3_table in the spmR package, but needs testing. it should do it already.

On Sun, Feb 27, 2022 at 12:16 PM Cole Monnahan @.***> wrote:

I'm only talking about the two columns from this year's proj output, not the previous. I feel like the latter is a different question. I maintain that chasing down individual components of the table from different proj output files is ripe for copy/paste or mistakes.

— Reply to this email directly, view it on GitHub https://github.com/afsc-assessments/Standard-Projection-Model/issues/3#issuecomment-1053666820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2OFRMJ5MNS4ZWYGJRWIM3U5KBAHANCNFSM5JVE53EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.*** com>

--

James Ianelli NMFS/NOAA Building 4 7600 Sand Pt Way NE Seattle WA 98115

206 526 6510

Visit the ADMB project http://admb-project.org/

Also see Alaska groundfish stock assessments https://www.fisheries.noaa.gov/alaska/population-assessments/north-pacific-groundfish-stock-assessment-and-fishery-evaluation

BenWilliams-NOAA commented 2 years ago

here is a "draft" version i've been working on https://github.com/ben-williams/safe_tbl

just need to have proj output placed in the "correct" format

Cole-Monnahan-NOAA commented 2 years ago

Why not have proj write it? Not everyone will use the R package.

BenWilliams-NOAA commented 2 years ago

that would be great! output could be used with many methods easily - you should update proj and i'll wrap it in a package for R users

Cole-Monnahan-NOAA commented 2 years ago

Is there going to be an R package for proj itself? Kinda makes sense to put some of this functionality along with the ADMB code.

jimianelli commented 2 years ago

Yes! Starting touches already happening

On Thu, Mar 3, 2022 at 8:04 AM Cole Monnahan @.***> wrote:

Is there going to be an R package for proj itself? Kinda makes sense to put some of this functionality along with the ADMB code.

— Reply to this email directly, view it on GitHub https://github.com/afsc-assessments/Standard-Projection-Model/issues/3#issuecomment-1058200873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUW7YU7Y2K7B2EWLYT5M2TU6DPILANCNFSM5JVE53EQ . You are receiving this because you modified the open/close state.Message ID: @.*** .com>

-- Jim Ianelli

BenWilliams-NOAA commented 2 years ago

I have one started up locally. brought up a number of framework questions for me. would also be easy to roll the AK_Scenarios_For_SS script that Steve has worked up into a package.

Also my info was based on the AK-projection-simulation repo, I'm guessing this repo usurps that?

jimianelli-NOAA commented 2 years ago

Thanks Ben,

Same repo, just renamed, wonder if that breaks things?!?

Great idear.

On Thu, Mar 3, 2022 at 8:40 AM Ben Williams @.***> wrote:

I have one started up locally. brought up a number of framework questions for me. would also be easy to roll the AK_Scenarios_For_SS script that Steve has worked up into a package.

Also my info was based on the AK-projection-simulation repo, I'm guessing this repo usurps that?

— Reply to this email directly, view it on GitHub https://github.com/afsc-assessments/Standard-Projection-Model/issues/3#issuecomment-1058243583, or unsubscribe https://github.com/notifications/unsubscribe-auth/AM2OFRLPW6R25LPEUQ7TC4TU6DTOBANCNFSM5JVE53EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.*** com>

--

James Ianelli NMFS/NOAA Building 4 7600 Sand Pt Way NE Seattle WA 98115

206 526 6510

Visit the ADMB project http://admb-project.org/

Also see Alaska groundfish stock assessments https://www.fisheries.noaa.gov/alaska/population-assessments/north-pacific-groundfish-stock-assessment-and-fishery-evaluation

jimianelli commented 1 year ago

guess prematurely closed