Closed EmilyMarkowitz-NOAA closed 2 years ago
@EmilyMarkowitz-NOAA Were you able to check to see if the label placement makes sense for the 'default' plotting options in the NBS?
Asking because the current place labels were setup for a really narrow use case: labeling default maps generated by make_idw_maps() for the SEBS shelf or EBS+NBS. Adding new regions using the current method may require tweaking label placement and angles, even if the features being labeled are the same as in regions that already exist.
For expanding coverage, I've been thinking that a better way of dealing with the labeling issue would be to use automatic labeling methods where anchor points for labels can be used to adjust label geometry to deal with different CRSs. Could be done by either setting point locations or using linestring geometry from the shapefiles. But I'm not sure it's worth the effort.
Will included to facilitate NBS labeling in the near-term. The long term solution will be to add dynamic labeling.
Without these changes you can only use bs.all or bs.south to return place.labels and not nebs or sebs, respectively. I'll probably add something about expanding this for nbs/bs.north later on.
e.g., in get_base_layers(): place.labels <- read.csv(file = system.file("data", "placenames.csv", package = "akgfmaps")) %>% dplyr::filter(region == select.region) %>% akgfmaps::transform_data_frame_crs(out.crs = set.crs)