search

afsc-gap-products / gap_products

This repository supports code used to create tables in the GAP_PRODUCTS Oracle schema. These tables include the master production tables, tables shared with AKFIN, and tables publicly shared on FOSS.
https://afsc-gap-products.github.io/gap_products/
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

Change TYPE field in AREA table to AREA_TYPE #11

Closed EmilyMarkowitz-NOAA closed 7 months ago

EmilyMarkowitz-NOAA commented 8 months ago

Suggestion

Change the TYPE field in GAP_PRODUCTS.AREA table to AREA_TYPE. Reasoning:

### Tasks
- [x] Change `TYPE` --> `AREA_TYPE` in [field metadata google spreadsheet](https://docs.google.com/spreadsheets/d/1wgAJPPWif1CC01iT2S6ZtoYlhOM0RSGFXS9LUggdLLA/edit#gid=1204955465)
- [x] Change `TYPE` --> `AREA_TYPE` field name in the [stratum google spreadsheet data](https://docs.google.com/spreadsheets/d/1v900jEaSPuWjyHzRJhY2RUFzO_c9FqOunow-RM77bHQ/edit#gid=427086090)
- [x] Change needs to be propagated through [`gapindex`](https://github.com/afsc-gap-products/gapindex)
- [x] Change needs to be propogated through [`gapindex`](https://github.com/afsc-gap-products/gapindex) call in [`gap_products`](https://github.com/afsc-gap-products/gap_products/blob/main/code/production.R)
zoyafuso-NOAA commented 7 months ago

These tasks were finished and the latest production run of the gap_products repo (11/14/2023) was fine.