afsc-gap-products / gap_products

This repository supports code used to create tables in the GAP_PRODUCTS Oracle schema. These tables include the master production tables, tables shared with AKFIN, and tables publicly shared on FOSS.
https://afsc-gap-products.github.io/gap_products/
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

[Data product request] : Historical Comparisons with EBS/NBS tables #13

Closed zoyafuso-NOAA closed 7 months ago

zoyafuso-NOAA commented 7 months ago

Data product requested: : Comparison of CPUE, biomass, size composition, and age composition tables between the HAEHNR (historical) vs GAP_PRODUCTS Oracle schemata.

Output type:: R script, RMarkdown script

**Species**: all species_codes **Region** : NBS (2010-2023); EBS + NW (1987-2023)

Research team making the request: @EmilyMarkowitz-NOAA @zoyafuso-NOAA

zoyafuso-NOAA commented 7 months ago

Hi @EmilyMarkowitz-NOAA, I finished up the comparisons for the four data tables. They are associated with this commit in a folder I created called bering_sea_shelf_comparisons. That folder has four elements:

I left the taxonomic comparisons as they are, there’s probably one more step that I’m missing there. I would encourage you to run the R script yourself so that it makes sense. Since the last time we met about this, I am now using integer codes which you can look up the descriptions in the error_codes.xlsx file instead of hard commenting the various comments. I came up with 15 codes across the four standard data tables. You can co-opt the text in the spreadsheet for the google document because I want to refrain from contributing as a co-author on the report, I will leave it up to you to form that text and will be available for clarification.

As for the markdown report, there's a lot of code in that script that I co-opted and used in the comparison script. The pieces should all be in the resulting RDS file from the script and the error_codes for the various explanations. As a result, I have not updated the mismatch_report.RMD.

EmilyMarkowitz-NOAA commented 7 months ago

This is great, thanks so much @zoyafuso-NOAA! I've done my initial work through on the data-changes google doc for the data report using what you prepared and have a few questions I've left for you in there. I ultimately did not use the mismatch_report.RMD for this because things felt so different for this year's data changes comparison and instead hand-wrote the content using the other 3 files you noted. I'll move the mismatch_report.RMD to the data report repo for future use and I think we may be able to simply delete that script from the gap_products repo.

Haha, I maintain that authorship is already yours if you want it. In my mind, the damage has long been done re: contributing to this publication, but it is entirely your call.