search

afsc-gap-products / gap_products

This repository supports code used to create tables in the GAP_PRODUCTS Oracle schema. These tables include the master production tables, tables shared with AKFIN, and tables publicly shared on FOSS.
https://afsc-gap-products.github.io/gap_products/
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

Better area descriptions in GAP_PRODUCTS.AREA table #17

Closed Duane-Stevenson-NOAA closed 6 months ago

Duane-Stevenson-NOAA commented 7 months ago

Can we provide better area descriptions for EBS subareas 1-9 in the GAP_PRODUCTS.AREA table?

The Description for Subarea 1 is "EBS Subarea 1", which is not very informative. These subarea designations do not exist for the EBS in RACEBASE.STRATUM. Based on some deduction, I can see that subarea 1 is equivalent to stratum 10, subarea 2 is equivalent to stratum 20, subarea 3 is equivalent to stratum 31 + 32 (which we used to call subarea 30, etc.

We need some kind of roadmap here, and I think better area descriptions will help. I suggest something like: "EBS Subarea 1 (= Stratum 10)" "EBS Subarea 2 (= Stratum 20)" "EBS Subarea 3 (= Stratum 31 + 32)" "EBS Subarea 4 (= Stratum 41 + 42 + 43)" "EBS Subarea 5 (= Stratum 50)" "EBS Subarea 6 (= Stratum 61 + 62)" "EBS Subarea 8 (= Stratum 82)" "EBS Subarea 9 (= Stratum 90)"

zoyafuso-NOAA commented 7 months ago

Thanks for the suggestion, Duane. I will throw this to @EmilyMarkowitz-NOAA because I'm not sure how changes to the DESCRIPTION field will affect her data report script (though I don't think it will).

EmilyMarkowitz-NOAA commented 7 months ago

Changes to the GAP_PRODUCTS.AREA.DESCRIPTION column won't affect anything for me or the data report script. @zoyafuso-NOAA are we still sourcing from the AREA table in the future oracle spreadsheet or somewhere else (e.g., directly in oracle)? If the former, feel free to add those edits directly to that tab, @Duane-Stevenson-NOAA, and they'll be added in the next run. @zoyafuso-NOAA - when are you planning on running these again? In the spring?

Duane-Stevenson-NOAA commented 7 months ago

OK, I have added those descriptions to the AREA tab.

Thank you,

Duane

EmilyMarkowitz-NOAA commented 7 months ago

Awesomeness, thanks @Duane-Stevenson-NOAA ! They look great.

zoyafuso-NOAA commented 7 months ago

We're still using the google sheets doc for updating the AREA table. Thanks Duane and Emily!

zoyafuso-NOAA commented 6 months ago

Duane's modifications have been updated in GAP_PRODUCTS.AREA (but not GAP_PRODUCTS.AKFIN_AREA yet).