search

afsc-gap-products / gap_products

This repository supports code used to create tables in the GAP_PRODUCTS Oracle schema. These tables include the master production tables, tables shared with AKFIN, and tables publicly shared on FOSS.
https://afsc-gap-products.github.io/gap_products/
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

Cleaning Up Our GAP_PRODUCTS.AREA Table #25

Closed zoyafuso-NOAA closed 4 months ago

zoyafuso-NOAA commented 4 months ago

@Ned-Laman-NOAA @Duane-Stevenson-NOAA @EmilyMarkowitz-NOAA

After meeting with @MattCallahan-NOAA and @jeanlee-akfin last week, we (they) found a bunch of mistakes in the AKFIN_AREA table that we have been delivering to them that I'd like to make right. I would like to remove records in GAP_PRODUCTS.AREA that are not a part of the standard surveys that we provide to AKFIN (AKFIN_AREA is a direct copy of GAP_PRODUCTS.AREA). Since a lot of these records were copied from RACEBASE.STRATUM, they will still have a home there even if we remove them here. Example of these include stratum records related to:

Please respond on this thread with either a thumbs up or with an objection and then I’ll make the changes accordingly.

EmilyMarkowitz-NOAA commented 4 months ago

I agree with these changes, as these are also per my understanding. Thanks for looking into this and cleaning this up, @zoyafuso-NOAA !

Duane-Stevenson-NOAA commented 4 months ago

I agree with these changes. I don't know for sure what strata were used for the 2000 EBS slope survey, and the strata are duplicated for DESIGN_YEAR = 2000, so we may need Jerry to clear that one up for us. As for the other BS slope strata (100, 110, etc.), these appear to be subareas roughly equivalent to "shallow slope south", "shallow slope north", "deep slope south", and "deep slope north". However, their DESIGN_YEAR corresponds with the shelf surveys, not the slope years, so I'm not sure they were ever used for anything.

Duane

On Sat, Feb 17, 2024 at 10:04 AM zoyafuso-NOAA @.***> wrote:

@Ned-Laman-NOAA https://github.com/Ned-Laman-NOAA @Duane-Stevenson-NOAA https://github.com/Duane-Stevenson-NOAA @EmilyMarkowitz-NOAA https://github.com/EmilyMarkowitz-NOAA

After meeting with @MattCallahan-NOAA https://github.com/MattCallahan-NOAA and Jean Lee last week, we (they) found a bunch of mistakes in the AKFIN_AREA table that we have been delivering to them that I'd like to make right. I would like to remove records in GAP_PRODUCTS.AREA that are not a part of the standard surveys that we provide to AKFIN (AKFIN_AREA is a direct copy of GAP_PRODUCTS.AREA). Since a lot of these records were copied from RACEBASE.STRATUM, they will still have a home there even if we remove them here. Example of these include stratum records related to:

  • GOA Winter Survey: already removed last week.
  • Bering Slope strata corresponding to DESIGN_YEAR = 2000. I’m making a guess that the 2000 version of the strata were used in the slope pilot study that occurred in 2000 but the BSS time series starts in 2002.
  • Bering Slope strata 100, 110, 120, and 130. Duane and I figured out that these were slope strata last Thursday but I don’t think these are strata used in produce an index, maybe they are referring to a separate survey? I’ll ask Jerry but chime in if you know what these are.

Please respond on this thread with either a thumbs up or with an objection and then I’ll make the changes accordingly.

— Reply to this email directly, view it on GitHub https://github.com/afsc-gap-products/gap_products/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANKDWAS5J3RYJYQP4I3C65TYUDWJDAVCNFSM6AAAAABDNPIY76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DAMZZGEZDIMI . You are receiving this because you were mentioned.Message ID: @.***>

-- Duane Stevenson, Ph.D. Supervisory Fish Biologist Groundfish Assessment Program NMFS, Alaska Fisheries Science Center

MattCallahan-NOAA commented 4 months ago

👍 Thanks Zack!

On Sat, Feb 17, 2024 at 9:04 AM zoyafuso-NOAA @.***> wrote:

@Ned-Laman-NOAA https://github.com/Ned-Laman-NOAA @Duane-Stevenson-NOAA https://github.com/Duane-Stevenson-NOAA @EmilyMarkowitz-NOAA https://github.com/EmilyMarkowitz-NOAA

After meeting with @MattCallahan-NOAA https://github.com/MattCallahan-NOAA and Jean Lee last week, we (they) found a bunch of mistakes in the AKFIN_AREA table that we have been delivering to them that I'd like to make right. I would like to remove records in GAP_PRODUCTS.AREA that are not a part of the standard surveys that we provide to AKFIN (AKFIN_AREA is a direct copy of GAP_PRODUCTS.AREA). Since a lot of these records were copied from RACEBASE.STRATUM, they will still have a home there even if we remove them here. Example of these include stratum records related to:

  • GOA Winter Survey: already removed last week.
  • Bering Slope strata corresponding to DESIGN_YEAR = 2000. I’m making a guess that the 2000 version of the strata were used in the slope pilot study that occurred in 2000 but the BSS time series starts in 2002.
  • Bering Slope strata 100, 110, 120, and 130. Duane and I figured out that these were slope strata last Thursday but I don’t think these are strata used in produce an index, maybe they are referring to a separate survey? I’ll ask Jerry but chime in if you know what these are.

Please respond on this thread with either a thumbs up or with an objection and then I’ll make the changes accordingly.

— Reply to this email directly, view it on GitHub https://github.com/afsc-gap-products/gap_products/issues/25, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUEK4TJWO6WT7EECHQPD7TYUDWJDAVCNFSM6AAAAABDNPIY76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DAMZZGEZDIMI . You are receiving this because you were mentioned.Message ID: @.***>

jeanlee-akfin commented 4 months ago

thanks @zoyafuso-NOAA. I didn't see any issues pertaining to:

-the issue with 793/794 area_id re-used for stratum and subarea by depth -renaming AI 'SUBAREA' and 'SUBAREA BY DEPTH' to' INPFC and INPFC BY DEPTH

is it appropriate to add these issues here or add new issue(s)?

zoyafuso-NOAA commented 4 months ago

@jeanlee-akfin: The renaming of the AI 'SUBAREA' and 'SUBAREA BY DEPTH' to' INPFC and INPFC BY DEPTH has already been updated on the AFSC Oracle Database (GAP_PRODUCTS.AKFIN_AREA) but I don't think it has been transferred to AKFIN yet.

The 793/794 issue is referenced in #28, hopefully that issue will get the ball rolling on that one.