search

afsc-gap-products / gap_products

This repository supports code used to create tables in the GAP_PRODUCTS Oracle schema. These tables include the master production tables, tables shared with AKFIN, and tables publicly shared on FOSS.
https://afsc-gap-products.github.io/gap_products/
Creative Commons Zero v1.0 Universal
5 stars 5 forks source link

gapindex version of the GOA Split Fractions Table #6

Closed zoyafuso-NOAA closed 8 months ago

zoyafuso-NOAA commented 8 months ago

Extending the conversation from afsc-gap-products/data-requests#76, putting in a request to use the gapindex R package to recreate the tables in GOA.SPLIT_FRACTIONS.

zoyafuso-NOAA commented 8 months ago

@Ned-Laman-NOAA

Just committed an R script that creates the GOA.SPLIT_FRACTIONS table using gapindex. In this folder of the repo, you'll see the R script that creates a csv file which shows the differences between the biomass output from the current SPLIT_FRACTIONS table (2019-2023) vs those created from gapindex.

Ned-Laman-NOAA commented 8 months ago

Thank you. This looks great. Where will we serve these data from?

zoyafuso-NOAA commented 8 months ago

I would consider this a non-standard data request and to not support this table in GAP_PRODUCTS going forward. Now that we have an R script that produces the same output using gapindex and GAP_PRODUCTS, it should be very easy to fulfil a request via the data-requests repo by simply changing the arguments in the gapindex::get_data() function OR provide the requesters that R script so they can do it themselves. Do you think either of those avenues are feasible going forward?

Ned-Laman-NOAA commented 8 months ago

In the future, split fractions from GOA will not be necessary because of restratification. Historically, we provided split fractions as a standard product for SAs and AKFIN. With those two bits of information in mind, and given that the requests I was fielding this year were to adjust groupings of rockfishes, I agree that going forward this can be a data request rather than a standard product and thus does not need to be formalized in GAP_PRODUCTS.