afsmith / cc

chinchilla
0 stars 0 forks source link

extra space in fouth attachment link #171

Open afsmith opened 10 years ago

afsmith commented 10 years ago

It looks like there's small parsing error (perhaps) in the fourth attachments generated link. For some reason the link hash has an extra space . If removed it works fine.

Here are the links just tested
Bilsan-pilotti<https://cc.kneto.com/view/575/1/?token=2bAzuQkZTMjGDab9pq4XYrxyBsg9rs>
Oppilaan pikaopas<https://cc.kneto.com/view/575/2/?token=2bAzuQkZTMjGDab9pq4XYrxyBsg9rs>
Howto re-submit<https://cc.kneto.com/view/575/3/?token=2bAzuQkZTMjGDab9pq4XYrxyBsg9rs>
Statistiikkaa<https://cc.kneto.com/view/575/4/?token=2bAzuQkZTMjGDab9pq4XYrxy%20Bsg9rs>

the last has an extra space (%20) before last 6 characters of the hash. Therefore when opening the link an error is generated "This link is expired. Please request another link from the sender."

afsmith commented 10 years ago

The above came from a user. In my testing I had this happen:

asdasd werwerwer [link3] fsdfdsf werwerew

link3 was not replaced.


<br><br><br><br><a href="https://cc.kneto.com/view/587/1/?token=YgoabKaTRjStgzlMMHH41FNGu6Ykt1">asdasd</a><br><a href="https://cc.kneto.com/view/587/2/?token=YgoabKaTRjStgzlMMHH41FNGu6Ykt1">werwerwer</a><br>[link3]<br><a href="https://cc.kneto.com/view/587/4/?token=YgoabKaTRjStgzlMMHH41FNGu6Ykt1">fsdfdsf</a><br><a href="https://cc.kneto.com/view/587/5/?token=YgoabKaTRjStgzlMMHH41FNGu6Ykt1">werwerew</a><br><br><div id="signature">Best Regards,<br><br>-----------------------------------------------------------<br>Andrew Smith<br>Mobile: +358 (0)40 773 8455<br>andrew.smith@kneto.com<br><br>Kneto<br>Kalevankatu 18 B<br>00100 Helsinki <br>Finland<br><br>kneto.com<br><br></div>
hieuh25 commented 10 years ago

There are 2 different problems in here:

  1. The problem from customer (?) when the space is inserted. I've tested the function on production with the same message and the output text looks good. So a hypothesis is that Sendgrid did something with the email (processing text?) or the email client of the customer did it. Could you get information of email client from customer for me? I will check around if a provider like Sendgrid can actually change the text message.
  2. It generated the problem in ticket #172 so I will take care of it there.
afsmith commented 10 years ago

Customer response: I used webclients (gmail/outlook webclient) & Outlook locally installed & iPhone mail client. All had the same problem in opening the last link when testing. This morning I did a few test emails and was also unable to replicate the problem. So perhaps it was just a one off glitch :) I'll let you know if it re-occurs.