search

afterschoolstudio / Depot

Structured data editor built inside VS Code
Apache License 2.0
205 stars 20 forks source link

.dpo file shows changes on vscode restart #52

Open Bloodyaugust opened 2 years ago

Bloodyaugust commented 2 years ago

Every time I restart VSCode, the file shows the edited icon over the "close" icon. Git doesn't show any changes. Perhaps a line-ending issue? I'm using VSCode on Win 10 Home:

Version: 1.63.2 (user setup)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

Attached is my .dpo file (file type changed so I can upload it). depot.txt

kkukshtel commented 2 years ago

I changed a bit of the backend in the latest release to push changes differently to the source file, in part due to some limitations with how Code works. Basically the editor is marked as dirty on open, often because it's loading some cached state. TBH we have a lot of issues at Afterschool with persistent saved state of files in Code, especially when the file gets updated "under" an open context in source control.

I think a fix here could be to better understand the file lifecycle in Code, as admittedly my understanding is bit out of date.