search

afterschoolstudio / Depot

Structured data editor built inside VS Code
Apache License 2.0
205 stars 20 forks source link

Schema edit Toolbar flickering. #64

Open Lucat79 opened 8 months ago

Lucat79 commented 8 months ago

The flicker of the schema edit toolbar is unnerving. Can it always be left visible?

https://github.com/afterschoolstudio/Depot/assets/34570632/8fbfcd6c-99ca-4c76-ab80-a1020666f6fd

kkukshtel commented 7 months ago

It looks like the "flickering" this is caused by a layout calculation error when hovering the border of the div like you're doing, but I don't think "always show" is something I would pursue as it would clutter the UI for any non-trivially nested Depot file. In the video you're also a bit of an edge case of the display — I think the error would go away if you scrolled up more and then hovered to edit the schema.

If you don't want to see the schema editing stuff you can also uncheck the "Allow Schema Editing" option at the top and just toggle it on when you need it.

Maybe an enhancement here could be like "pinning" a schema editing context to a row? Not sure.