AG-13008, AG-13041 Fix Delete/Escape key deleting the annotation in text-edit mode

ag-grid / ag-charts

AG Charts is a fully-featured and highly customizable JavaScript charting library. The professional choice for developers building enterprise applications

https://charts.ag-grid.com

Other

157 stars 10 forks source link

AG-13008, AG-13041 Fix Delete/Escape key deleting the annotation in text-edit mode #2605

Closed olegat closed 3 days ago

olegat commented 6 days ago

https://ag-grid.atlassian.net/browse/AG-13008 https://ag-grid.atlassian.net/browse/AG-13041

olegat commented 4 days ago

There's been a lot of back and forth on deleting annotations due to changes in interactions.

Please make sure any changes continue to work for both of these fixes:

Ag 12476/annotations floating toolbar delete functionality #2160

AG-12598 Fix escape to cancel creating annotation #2454

I've checked these.

✅ AG-12476 - No regression ✅ AG-12598 - No regression

olegat commented 4 days ago

Rebased and resolved conflict by dropping the e2e snapshot update to this file: packages/ag-charts-website/e2e/zoom.spec.ts-snapshots/zoom-crosshairs-after-wheel-zoom-chromium-linux.png