agGridColumn: missing column properties - Githubissues

ag-grid / ag-grid-aurelia

Aurelia wrapper for ag-Grid project

MIT License

23 stars 8 forks source link

agGridColumn: missing column properties #25

Open mroseboom opened 6 years ago

mroseboom commented 6 years ago

I'm submitting a ...

[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/ceolter/ag-grid-aurelia/blob/master/CONTRIBUTING.md#question

Current behavior agGridColumn does not support the following properties:

suppressToolPanel
suppressKeyboardEvent(params)

Expected behavior agGridColumn should support those attributes

What is the motivation / use case for changing the behavior? Should be able to use the built-in column properties on the ag-grid-column component.

Please tell us about your environment:

ag-grid-aurelia version: 16.0.0
ag-Grid/ag-Grid-Enterprise version: 16.0.0
Aurelia version: 16.0.0
Browser: all
Language: all

ShaunVanDyk commented 6 years ago

Is rowDrag also missing? This was added in v16: https://www.ag-grid.com/javascript-grid-row-dragging/#managed-dragging

mroseboom commented 6 years ago

@ShaunVanDyk You're right, the property rowDrag is also missing. I'll add that one too.

mroseboom commented 6 years ago

Added both new properties rowData and toolPanelClass in the pull-request

avrahamcool commented 6 years ago

looks like lockPinned is also missing.

https://www.ag-grid.com/javascript-grid-pinning/

mroseboom commented 6 years ago

@avrahamcool lockPinned is added.