search

ag-grid / ag-grid-aurelia

Aurelia wrapper for ag-Grid project
MIT License
23 stars 8 forks source link

fix(agGridColumn): add missing attributes #26

Closed mroseboom closed 6 years ago

mroseboom commented 6 years ago

add support for the properties suppressToolPanel & suppressKeyboardEvent within the grid-column. This pr is a fix for issue #25

mroseboom commented 6 years ago

Is it an idea to use the colDefUtil file for the bindable properties?

Example usage:

import { ColDefUtil } from "ag-grid/main";

@customElement('ag-grid-column')
@generateBindables(ColDefUtil.ALL_PROPERTIES) <--
// <slot> is required for @children to work.  https://github.com/aurelia/templating/issues/451#issuecomment-254206622
@inlineView(`<template><slot></slot></template>`)
@autoinject()
export class AgGridColumn {
   ...
}
mroseboom commented 6 years ago

@seanlandsman Do you have an idea when this pr can be merged?

mroseboom commented 6 years ago

any update on when this pull-request can be reviewed/merged?

seanlandsman commented 6 years ago

Hi

Apologies for the delay - this project is now deprecated. The replacement repo can be found at https://github.com/ag-grid/ag-grid.

I've manually taken this PR and applied it to the new repo. The changes will be available in the next release.

thanks for the PR!