search

ag-grid / ag-grid-aurelia

Aurelia wrapper for ag-Grid project
MIT License
23 stars 8 forks source link

fix(agGridColumn): default column definition not applying #27

Closed ShaunVanDyk closed 6 years ago

ShaunVanDyk commented 6 years ago

Don't map column properties which are undefined. This prevents default column settings from being applied within the grid (because the property is present), and stops attributes like type from working. This pr Closes #24

ShaunVanDyk commented 6 years ago

It turns out there were 2 separate issues. 1) By setting all properties as undefined, it prevented default columns and type definitions from being applied as the column itself has a "definition" of undefined and that has the highest precedence in ag-grid. Commit 497d79f fixes that. 2) I still found editable didn't apply properly. This was because the edit template set editable on the column to true if it was undefined. Maybe this is trying to be helpful so the user doesn't have to set the property if they provide an editable template, but it actually breaks the default behaviour of ag-grid. Providing editable in the default column no longer works, or providing it in a column type no longer works. Fixed in commit 4442c3b. NOTE: This is actually a breaking fix, as developers who haven't set editable explicitly will no longer have editable columns until they set the property themselves.

mroseboom commented 6 years ago

any update on when this pull-request can be reviewed/merged?

seanlandsman commented 6 years ago

Hi - apologies for the delay.

This fix has already been applied and should be available now.

thanks for the PR