ag-grid / ag-grid

The best JavaScript Data Table for building Enterprise Applications. Supports React / Angular / Vue / Plain JavaScript.
http://www.ag-grid.com
Other
12.7k stars 1.86k forks source link

Custom themes don't work #8362

Closed gespinha closed 3 months ago

gespinha commented 3 months ago

I'm submitting a ... (check one with "x")

[x] bug report => see 'Providing a Reproducible Scenario'
[] feature request => do not use Github for feature requests, see 'Customers of AG Grid'
[] support request => see 'Requesting Community Support'

Customers of AG Grid

If you are a customer you are entitled to use the AG Grid's customer support system (powered by Zendesk). Please use that channel for guaranteed response from the AG Grid team with regards bugs, feature requests and support.

Requesting Community Support

If you are not a customer of AG Grid, ag-grid staff will label your issue as managed-by-the-community. This means that AG Grid staff is not going to be actively looking into it and it will get closed if inactive for more than one month. The community is welcome to help with this question/support issue.

Providing a Reproducible Scenario Accepted reproducible scenarios are

If you decide to send us a plunker, from any example in our website use the plunker button in there to fork your own code by following the steps below:

If reporting a bug make sure to state.

Current behaviour. Expected behaviour. If possible back this up with our docs/examples if possible

Current behavior

Expected behavior

Please tell us about your environment: VueJs app running in a Docker container

bbeas commented 3 months ago

same problem with AGGridReact. AG Grid version: 31.2.1 The css file downloaded from theme-builder seems incorrect. Following the instructions here doesn't work. https://www.ag-grid.com/react-data-grid/applying-theme-builder-styling-grid/

AG-Zoheil commented 3 months ago

Hi,

Thank you for reporting this.

We'd be happy to look into this, but the most efficient way for us to do so would be for you to provide a live example reproducing the issue.

Please send us a live plunker sample which shows the issue. You can use one of the examples from our website as a starting point. Do let us know if you need further guidance on this.

We're looking forward to your response.

Kind regards, Zoheil

gespinha commented 3 months ago

Hi,

Thank you for reporting this.

We'd be happy to look into this, but the most efficient way for us to do so would be for you to provide a live example reproducing the issue.

Please send us a live plunker sample which shows the issue. You can use one of the examples from our website as a starting point. Do let us know if you need further guidance on this.

We're looking forward to your response.

Kind regards, Zoheil

Sure! I've created a working example here

In that example, you'll see a screenshot of what I created in Theme Builder and below a working example of what I got by following this guide.

BernieSumption commented 3 months ago

Hi,

The issue is that your downloaded theme is for v32.0 and your grid is on v31.0. For the moment (we're currently working on lifting this restriction) theme builder downloads can only be used with the current version of the grid.

You can either update your grid to 32.0, or use an older version of Theme Builder. You can access old versions of Theme Builder in our archive, e.g. https://ag-grid.com/archive/31.3.0/theme-builder/

Theme Builder was released with version 31.3 so in any case you'd need to update from 31.0 to 31.3.