search

ag91 / moldable-emacs

Adapting Emacs for moldable development
GNU General Public License v3.0
105 stars 8 forks source link

Eldev support suggestion #16

Closed ikappaki closed 2 years ago

ikappaki commented 2 years ago

Hi,

would you consider using a build tool for moldable-emacs that will greatly facilitate development any further?

I found it difficult earlier to run the tests while looking at #14, and though it will be a good idea to introduce Eldev for the task, if not for everything else.

The only changes required are to add the Eldev configuration file and include the package info at the top of moldable-emacs.el.

Then the tests can be run with eldev test, with the added benefit they are now run in isolation, only using the dependent packages and nothing else in a clean setup. The tests are further consider by the CI as a GitHub action with `.github/workflows/test.yml' so as to run every time there is a commit.

Moreover, Eldev has more to offer such as package creation, linting etc, which greatly helps with the whole management lifecycle.

Let me know what you think. Eldev is a quite mature build tool and is used by quite popular packages such as CIDER.

Thanks,

https://github.com/doublep/eldev

ag91 commented 2 years ago

Oh, thanks! I think it is a wonderful idea. I have been playing around so far, but I guess it would improve life for everybody if we have some easy way to test things. Let me have a look in eldev and try it out.

ikappaki commented 2 years ago

Oh, thanks! I think it is a wonderful idea. I have been playing around so far, but I guess it would improve life for everybody if we have some easy way to test things. Let me have a look in eldev and try it out.

Please also try out the linter with eldev lint, as well as eldev package to create a package out of the project (that would be very useful when the project is ready to publish at MELPA).

I will be more than happy to look at the linter errors if you are happy to go ahead with Eldev.

Thanks

ag91 commented 2 years ago

Thanks, I tried all the commands you suggested and it looks amazing. I think we could merge as is and then I can fix the package details. I was planning to give a look at the linters complaining at some point but I didn't allocate the time yet :P For now I am giving a look at the (long) list to make sure I don't introduce more XD

Thanks again! You contribution is making this extension much more mature :D

ikappaki commented 2 years ago

Thanks, I tried all the commands you suggested and it looks amazing. I think we could merge as is and then I can fix the package details. I was planning to give a look at the linters complaining at some point but I didn't allocate the time yet :P For now I am giving a look at the (long) list to make sure I don't introduce more XD

Thanks again! You contribution is making this extension much more mature :D

Glad you liked it :) I've made some minor changes (removed tree-sitter as main dependencies, but marked them as required in the Eldev file for the purpose of running the tests). I've also dropped a line in the readme about running the tests. Squashed and ready to commit when you feel like it :)

ag91 commented 2 years ago

thanks you a lot for proposing and contributing this! It is great like this :)