Closed kelilipan closed 3 years ago
idk, pnpm detect my node version as "15.x" but I'm using "14.xLTS" so I'm disabling "strict". also, I'm disabling some eslint rules because error
can you please check before merge this?
Sure! Will do. Checking
Can you improve this not-so-readable text too @svspicious?
done
Please fix this z-index issue @svspicious
hmm, the button already on the top of another component, right? i don't see any issue
Hmmm, so I think it's an opacity issue. Could you check so the white border doesn't overlap with the button?
ahhh, ok changing the color
is this enough?
i think the button will conflict with #16 layout but we'll figure out later
It's still showing the white border from the HospitalCard component 🤔
dang, it's from active
button. CSS is hard wkw
it should be fixed now
Wkwkwkwk dang. 🤣 Okay thanks, lemme check
@svspicious please check if there's any issues for the button after rebased with the main branch
i know it will overlap on map
page.
any suggestion? or should we disable this on map page?
it becomes unreadable since the style is not inherited from chakra-ui
Hmmm can we disable the Chakra-UI dark mode on map page?
unfortunately, we can't. well, I will refactor map page using all chakra-ui
https://chakra-ui.com/docs/features/color-mode#forcing-a-specific-mode only works on chakra component
i simply add color="black"
and it works
UPDATE:
i'm sorry wrong executing rebase command :( should I repoen this PR?
Yes please @svspicious. Thank you 🙇🏻
Add dark mode toggle