agallio / ina-covid-bed

Covid bed availability for all provinces in Indonesia
68 stars 26 forks source link

Feat: dark mode button #18

Closed kelilipan closed 3 years ago

kelilipan commented 3 years ago

Add dark mode toggle image

kelilipan commented 3 years ago

idk, pnpm detect my node version as "15.x" but I'm using "14.xLTS" so I'm disabling "strict". also, I'm disabling some eslint rules because error

can you please check before merge this?

agallio commented 3 years ago

Sure! Will do. Checking

agallio commented 3 years ago

Can you improve this not-so-readable text too @svspicious?

image

kelilipan commented 3 years ago

done image

agallio commented 3 years ago

Please fix this z-index issue @svspicious

image

kelilipan commented 3 years ago

hmm, the button already on the top of another component, right? i don't see any issue

agallio commented 3 years ago

Hmmm, so I think it's an opacity issue. Could you check so the white border doesn't overlap with the button?

kelilipan commented 3 years ago

ahhh, ok changing the color

kelilipan commented 3 years ago

is this enough? 2yUupSv69o

i think the button will conflict with #16 layout but we'll figure out later

agallio commented 3 years ago

It's still showing the white border from the HospitalCard component 🤔

kelilipan commented 3 years ago

dang, it's from active button. CSS is hard wkw it should be fixed now

agallio commented 3 years ago

Wkwkwkwk dang. 🤣 Okay thanks, lemme check

agallio commented 3 years ago

@svspicious please check if there's any issues for the button after rebased with the main branch

kelilipan commented 3 years ago

i know it will overlap on map page. any suggestion? or should we disable this on map page? image

kelilipan commented 3 years ago

it becomes unreadable since the style is not inherited from chakra-ui image

agallio commented 3 years ago

Hmmm can we disable the Chakra-UI dark mode on map page?

kelilipan commented 3 years ago

unfortunately, we can't. well, I will refactor map page using all chakra-ui

agallio commented 3 years ago

Wait. I think we can force the page to use light mode only. See this

kelilipan commented 3 years ago

https://chakra-ui.com/docs/features/color-mode#forcing-a-specific-mode only works on chakra component i simply add color="black" and it works

kelilipan commented 3 years ago

UPDATE: image

Screenshot 2021-07-09 091944 Screenshot 2021-07-09 091931

image

kelilipan commented 3 years ago

i'm sorry wrong executing rebase command :( should I repoen this PR?

agallio commented 3 years ago

Yes please @svspicious. Thank you 🙇🏻