initialize_target_repos still referenced

agama-project / agama

A service-based Linux installer

https://agama-project.github.io/

GNU General Public License v2.0

147 stars 44 forks source link

Open mvidner opened 5 months ago

mvidner commented 5 months ago

Reading Agama::Software::Manager code I found a method call that is not defined. https://github.com/openSUSE/agama/blob/c9a68ce2441a2b73e2af6feae0ee70968e7dca92/service/lib/agama/software/manager.rb#L338 It turns out it is a bug in a recent refactoring, #1329.

mvidner commented 5 months ago

The fix is trivial, the method was renamed to initialize_target to better reflect what it does. Should we have tests covering this?

imobachgs commented 5 months ago

Good catch. It looks like it is related to the registration. And, yes, I think it might be a good idea to have at least a minimal test.

Let's plan to get this fixed in Agama 10.