search

agama-project / agama

A service-based Linux installer
https://agama-project.github.io/
GNU General Public License v2.0
143 stars 43 forks source link

fix(web): use right type for icon name at core/EmptyState #1711

Closed dgdavid closed 3 weeks ago

dgdavid commented 3 weeks ago

Problem

Unfortunately, https://github.com/agama-project/agama/pull/1690 broken a type import at core/EmptyState component that has been cough by OBS

Solution

To use the right type (https://github.com/agama-project/agama/commit/d9554b145904d0eb2883d61b8f1cd4d7f0c6e9dd) and take the opportunity for migrating the component to TypeScript (https://github.com/agama-project/agama/commit/9719d0b201e7f1d861062e18fd9748a3e9c50373) which makes possible to get rid of a @ts-expect-error directive (https://github.com/agama-project/agama/commit/749db9e4d9c2a49d2c6b0ebb601d0ed1ae0dc961)

Testing

Tested manually by running NODE_ENV=production npm run build