search

agama-project / agama

A service-based Linux installer
https://agama-project.github.io/
GNU General Public License v2.0
143 stars 43 forks source link

Update storage when product changes #411

Closed joseivanlopez closed 6 months ago

joseivanlopez commented 1 year ago

When a new product is selected, some information provided by the storage service has to be reset, for example, the storage proposal or the volume templates. Currently, the storage service only refreshes its data if a probing is explicitly requested. With the current D-Installer workflow everything gets refreshed because the following actions are done:

a) A product is selected and software service emits a signal. b) Main D-Installer service reacts to the software signal and calls to storage service in order to perform a new proposal. c) Storage service calculates a new proposal for the currently selected product.

But, what happens if the main service fails to request the probing action to the storage service?

Actually, the storage service could react by itself when a product is selected. So, it could invalidate its proposal, etc, right after changing the product.

joseivanlopez commented 6 months ago

Fixed by https://github.com/openSUSE/agama/pull/1236. That PR ensures a PropertiesChanged signal is emitted when needed, although the current proposal is not automatically removed (note that the Manager service always requests a default proposal after selecting a product).