Simplify code for DASD and iSCSI D-Bus trees

agama-project / agama

A service-based Linux installer

https://agama-project.github.io/

GNU General Public License v2.0

144 stars 43 forks source link

Simplify code for DASD and iSCSI D-Bus trees #605

Open joseivanlopez opened 1 year ago

joseivanlopez commented 1 year ago

There are a lot of similar code in the classes for exporting a DASD and iSCSI D-Bus trees. A new base class DBus::TreeBase was introduced as part of the zFCP devices support, see https://github.com/openSUSE/agama/pull/594. The code of DasdsTree and ISCSINodesTree can by simplified by inheriting from BaseTree.

mvidner commented 1 year ago

Do you feel that ruby-dbus should include some of this to make applications' lives easier? I haven't checked your API yet, maybe it does not generalize.

joseivanlopez commented 9 months ago

Do you feel that ruby-dbus should include some of this to make applications' lives easier? I haven't checked your API yet, maybe it does not generalize.

Not sure, I think ruby-dbus already offers everything we need from the server side. But maybe we would need more at client side. For example, some way to listen to changes in the tree.