agamemnus / cordova-plugin-xapkreader

Easily access Google Play APK expansion file data.
32 stars 55 forks source link

public API key #123

Closed BobAchgill closed 5 years ago

BobAchgill commented 6 years ago

Sorry for the Newby question... Is it enough to just copy/paste the Google Play Public key to replace ""Your Google Play public API key"" ??

<plugin name="com.flyingsoftgames.xapkreader" spec="https://github.com/agamemnus/cordova-plugin-xapkreader.git#cordova-6.5.0">
        <variable name="XAPK_PUBLIC_KEY" value="Your Google Play public API key" />
    </plugin>

Because when I run ...

cordova build android --release

I only find an unsigned release apk.

agamemnus commented 6 years ago

Latest version should let you set that on install. Replacing it within the plugin install doesn't do anything unless you clear all generated code.

On Tue, Apr 24, 2018, 4:48 PM BobAchgill notifications@github.com wrote:

Sorry for the Newby question... Is it enough to just copy/paste the Google Play Public key to replace ""Your Google Play public API key"" ??

Because when I run ...

cordova build android --release

I only find an unsigned release apk.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/agamemnus/cordova-plugin-xapkreader/issues/123, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFJWJoxbDdzYvebc1O0LJgmx50TcghZks5tr4-ngaJpZM4TiZII .

BobAchgill commented 6 years ago

unless you clear all generated code

by this you mean going back to the Create project step?

cordova create MyProject copied in my config.xml with the Google Play public key value set cordova platform add android@5.1.1 cordova build android --release

... and still got an unsigned release apk.

agamemnus commented 6 years ago

Wait, unsigned release APK? That's not what signs it. Read this:

https://ionicframework.com/docs/v1/guide/publishing.html