agamjotsingh18 / pollitup

Live Website👇
https://pollitup.vercel.app/
MIT License
29 stars 64 forks source link

login and register form validation and error message [Development and correction] GSSOC'23 #90

Open Pushpendra33 opened 1 year ago

Pushpendra33 commented 1 year ago

Hi there @agamjotsingh18 ,

Login and Register Forms can be imporve very much by adding validation messages and error messages at right places. First i will add Global components for Forms, inputs and submit with onChange functionality which will help to improve the accessability and productivity of code.

After that i will add form validation by which proper error message will show on fields. I will also design the current error message from mid to left side so that login and register buttons and input fields will not overlape each other. Screenshot from 2023-05-23 13-25-35 Screenshot from 2023-05-23 13-25-44

Please assign me this issue under GSSOC'23.

Pushpendra33 commented 1 year ago

please assign me this issue under GSSOC'23

agamjotsingh18 commented 1 year ago

Sure @Pushpendra33, go ahead

Pushpendra33 commented 1 year ago

I'm getting issues with your current code of chakra/ui/react can i change it according to my convenience, i want to add all the inputs in one file so that i can add validation and error messages.

aceta-minophen commented 1 year ago

I'm getting issues with your current code of chakra/ui/react can i change it according to my convenience, i want to add all the inputs in one file so that i can add validation and error messages.

@Pushpendra33 what issues are you facing?

Pushpendra33 commented 1 year ago

Actually while i was adding my custom error messages in register form, at that time as you are using chakra/ui so the form,inputs and button are inbuilt from chakra/ui so i tried my code to maintain all fields email,password and confirmPassword in a single file but then design issues comes because of chakra/ui so i decided to go with your chakra/ui code and settled error popups according to ui.

Pushpendra33 commented 1 year ago

please look at the screenshots i am attaching if its ok then i will push code Screenshot from 2023-05-24 12-31-56 Screenshot from 2023-05-24 12-31-44

YOU CAN CHECK THE POSITION OF TOAST IS NOW FIXED AT TOP RIGHT CORNER>>>>>>>>>>

Pushpendra33 commented 1 year ago

Please let me know if commit from my side is ok or not @aceta-minophen @agamjotsingh18