[CODE] Plugin as a class

agamm / comeback

Project restoration in one command, auto open everything!

MIT License

22 stars 5 forks source link

[CODE] Plugin as a class #30

Open yoavgolan opened 5 years ago

yoavgolan commented 5 years ago

Creating a Plugin class will help create:

logical inheritance of plugins (like: Plugin->IdePlugin->PycharmPlugin)
clear and enforceable interface for a plugin (like: run, check etc...)
common code for all plugins (for example: Determining the OS and running the correct run function)

agamm commented 5 years ago

This is a great idea! I like your second and third points the most. PS, if you have time 🤞, you are welcome to work on it. Here, you are awesome in any case.

agamm commented 5 years ago

What do you think about keeping the run_plugin and having the class, so people could choose if they want to use classes or not? or will it make a mess? @yammesicka @yoavgolan

yammesicka commented 5 years ago

Maybe we can add some @shitty_decorator that will wrap functions to make it compatible :)

@look_at_me_im_a_plugin_class
def run_plugin(params):
    pass

agamm commented 5 years ago

Maybe we can add some @shitty_decorator that will wrap functions to make it compatible :)
@look_at_me_im_a_plugin_class
def run_plugin(params):
    pass

That's cool. That way we keep both ways working, right?