search

agamm / comeback

Project restoration in one command, auto open everything!
MIT License
22 stars 5 forks source link

[FEATURE] Add a terminal plugin #31

Open agamm opened 5 years ago

agamm commented 5 years ago

Is your feature request related to a problem? Please describe. Currently, you can't open terminals. Which is quite essential.

Describe the solution you'd like a terminal plugin like so:

terminal:
  cwd: <somepath>
  cmd: <a command I can run>
yammesicka commented 5 years ago

We should consider the security problems that may arise in this plugin. (Command Injection is only cool when you're on the red team)

agamm commented 5 years ago

@yammesicka hmm it's something that is prevalent in many places right now, how do you want to stop it? Mainly what I think is that this is a file that wouldn't go into production, in addition, why would you run comeback in production? We can try to detect and ask the user if he specifies before running unwanted codes (https://github.com/Mckinsey666/bullet ?)

yammesicka commented 5 years ago

I just think of a user who runs .comeback recipe and don't think about the possibility of command injection.

agamm commented 5 years ago

I just think of a user who runs .comeback recipe and d

It can happen right now, what do you propose?