search

agapoff / check_kubernetes

Nagios/Icinga/Zabbix style plugin for checking Kubernetes
64 stars 36 forks source link

Condition OutOfDisk #41

Open Spuxy opened 6 months ago

Spuxy commented 6 months ago

Hey ! Is there still any reason hold this condition OutOfDisk (.spec.conditions[].type=="OutOfDisk")? reportedly to this issue, it should not be relevant anymore In code: https://github.com/agapoff/check_kubernetes/blob/4cdf0f1bf50dcc6c655726db1750cf53be3f570a/check_kubernetes.sh#L201

agapoff commented 6 months ago

It is likely worth wiping it out. The backward compatibility of such depth is barely required.

Spuxy commented 6 months ago

I can make PR for that, if thats okay for you

agapoff commented 6 months ago

Sure, would be great.