search

agateau / nanonote

A minimalist note taking application
Other
59 stars 11 forks source link

Sync from cookiecutter-qt-app #32

Closed agateau closed 1 year ago

agateau commented 1 year ago

Add a full English translation and synchronize with cookiecutter-qt-app architecture. This is hopefully going to help with maintenance.

@dlaidig would be great if you could try the .dmg output of this, since I can't test it personally.

dlaidig commented 1 year ago

I did some testing and it all seems to work as before.

With my default "first English, then German" setting, the context menu is still fully in English. Then I swapped the language order (and also tried setting it to German-only) and noticed that the Nanonote-specific strings are translated to German but standard strings like "Copy" and "Paste" remain in English.

(The funny thing is that macOS urges you to reboot after changing the language. Also tried that.)

However, this is not a new issue but also happens with the 1.3.0 .dmg from the release page. It's not something I personally care about, but if you some idea how to fix that, I'm happy to test again.

I didn't systematically test every single feature, but from playing around a bit, everything seems to work fine.

agateau commented 1 year ago

Thanks for testing. Regarding your language issue, I suspect this is because Nanonote does not load translations from the Qt library itself. This is where the standard actions are translated. Going to look into this.

agateau commented 1 year ago

I have a fix for the translation issue, but I am going to open a separate PR for this. Merging this one first.