Closed Justinzobel closed 1 year ago
Thanks for starting this work! If it makes your life easier I can probably drop the qpropgen dependency. Let me know.
It would be great if it's easy enough to drop without causing issues or losing any functionality. Fewer dependencies are always welcome.
Just removed it!
Well that made it extremely easy. I've just tested it and I can launch it and it saves the content to ~/.var/app/com.agateau.nanonote/data/agateau.com/nanonote/nanonote.txt
I guess if i enable some other home directory permission from within the flatpak it could save it in the regular location, will test.
Even with the home filesystem permission it still drops the file in the flatpak folder, I guess that's fine as the UI does show the location of the file correctly: file:///home/justin/.var/app/com.agateau.nanonote/data/agateau.com/nanonote/nanonote.txt
Sounds good enough indeed! Thanks!
Would you like me to submit it to Flathub or would you like to do it so it can be verified?
Oh, I didn't know about Flathub verification feature! Indeed it would be better if I submit it myself.
I think the best solution to do this is for me to clone Flathub repo as explained in their docs and give you write access to the fork so you can push your changes. Does this make sense?
Yeah I submitted an app to flathub a few years ago, couldn't remember the process.
This is the file, save it as com.agateau.nanonote.yml
app-id: com.agateau.nanonote
runtime: org.kde.Platform
runtime-version: '5.15-21.08'
sdk: org.kde.Sdk
command: nanonote
finish-args:
- --socket=x11
- --socket=wayland
modules:
- name: nanonote
buildsystem: cmake
sources:
- type: git
url: https://github.com/agateau/nanonote.git
This is a git master build as obviously that's where the removal of qpropgen happened. If you want to release it as a versioned release you'll have to tag a release on github.
If you do that you just change the sources to:
type: archive:
url: https://link.to.github/someversion.tar.gz
sha256: sha256sum of tarball here
Thanks a ton!
Here is the PR: https://github.com/flathub/flathub/pull/4003 I made a few changes:
Looks good, they have asked for an appstream data file to be added in the merge request.
Looks good, they have asked for an appstream data file to be added in the merge request.
Do you have time to look into this? I just added you as a collaborator to the https://github.com/agateau/flathub/ repo so you can push changes to the nanonote
branch. Note that it's a generic repo because due to the way flathub works, the app does not get its own repo until the first PR gets accepted (see https://github.com/flathub/flathub/wiki/App-Submission#how-to-submit-an-app)
It's done!
Nice work, sorry I didn't get time to get this sorted out but looks like you got it all sorted!
I'm building the flatpak at the moment, well, trying to.
I have the two qpropgen python3 modules being installed first, then it tries to build nanonote but I get this:
I've tried adding a build for Markupsafe from pypi but it says it's already installed and tries to uninstall it, which fails: