agateau / sfxr-qt

Qt port of SFXR, a sound effect generator, to generate retro-gaming like sound effects.
MIT License
74 stars 13 forks source link

Incompatible file formats #28

Open tpimh opened 3 weeks ago

tpimh commented 3 weeks ago

I have found that the file formats used by sfxr-qt (.sfxr and .sfxj) are not compatible with other implementations of sfxr. Would be nice if JSON was in the same format as jsfxr is using and the binary .sfs format (very simple).

I've made a Kaitai Struct description of the binary format: sfs.ksy It seems that this function should produce the file in the correct format, the only difference is the file extension: https://github.com/agateau/sfxr-qt/blob/5abb01cea8d297cc4e6af64ac433bc578f044f0b/src/core/SoundIO.cpp#L154

agateau commented 1 week ago

Hi, I have little time available for sfxr-qt these days, so I would not be working on this myself, but if you are interested in implementing support for these formats, I'd be happy to review and integrate it. The .sfs format looks very similar to the .sfxr format so that should be doable.