search

agateblue / django-dynamic-preferences

Dynamic global and instance settings for your django project
https://django-dynamic-preferences.readthedocs.org/
BSD 3-Clause "New" or "Revised" License
350 stars 87 forks source link

Fix model multiple choice preference to react correctly to deletion handler #244

Closed hansegucker closed 3 years ago

hansegucker commented 3 years ago

If you delete an object whose model is also used for a model multiple choice preference, it will cause some trouble because the preference uses create_deletion_handler to create a handler for the delete signal of this model. For a normal model choice field that works perfectly, but not for a model multiple choice field: The serializer only supports querysets and not single objects as provided through the signal handler.

hansegucker commented 3 years ago

@agateblue Is there any progress on this topic? It would be nice to get at least some feedback because this a very critical bug in our school information system AlekSIS.

agateblue commented 3 years ago

Hi @hansegucker. Apologies for the delay and thank you for the contribution. Let's merge and I'll try to make a release next week.

Take care

hansegucker commented 3 years ago

Hi @hansegucker. Apologies for the delay and thank you for the contribution. Let's merge and I'll try to make a release next week.

Thanks for merging, @agateblue! Is there any progress with releasing a new version?