search

agateblue / tempo

Your personal diary and mood tracker
GNU Affero General Public License v3.0
106 stars 12 forks source link

Added dockerfile #64

Closed andrej-s closed 1 year ago

andrej-s commented 1 year ago

Hello, thank you for this great project! I am using tempo inside a Docker container and thought you might be interested in adding this to your repo.

Anyways, thanks again, Agate.

andrej-s commented 1 year ago

More than happy to do so, @agateblue - one question though: I am not sure adding node_modules to a dockerignore file, as there is no such folder on your repo, and when copying data to the final image, we only copy the build folder - the final image is as sleek as can be. Maybe I am misunderstanding. Just let me know if you'd like me to still add a dockerignore and I'll happily oblige.

agateblue commented 1 year ago

More than happy to do so, @agateblue - one question though: I am not sure adding node_modules to a dockerignore file, as there is no such folder on your repo, and when copying data to the final image, we only copy the build folder - the final image is as sleek as can be. Maybe I am misunderstanding. Just let me know if you'd like me to still add a dockerignore and I'll happily oblige.

Sorry, I should have given more context: in a local/dev environment where you try or work on Tempo with and without docker, node_modules exists and building the image can take a while because this folder is passed into the docker build context ;)

andrej-s commented 1 year ago

Perfect, makes sense! I followed both your suggestions.