search

agavi / agavi

A powerful, scalable PHP5 application framework that follows the MVC paradigm
Other
104 stars 34 forks source link

Shiny exception template may produce invalid XHTML #1240

Closed johnutzm closed 14 years ago

johnutzm commented 14 years ago

You can get invalid XHTML from shiny.php if you got an exception in an action, after a opening php tag preceded by a newline and one or more spaces or tabs.

More details and a possible fix here: http://trac.agavi.org/ticket/1009#comment:10

I know it may be strange to open and close php tags inside an action, but im my case I got the invalid XHTML when an exception was thrown from a compiled PHPTAL template. I gave that example to show that it is not an PHPTAL-related issue.

dzuelke commented 14 years ago

Title changed from "Shiny exception template can still produce invalid XHTML" to "Shiny exception template may produce invalid XHTML"

dzuelke commented 14 years ago

Labels changed from [normal, defect, v1.0.x] to [normal, defect, v1.0.x, exception]

dzuelke commented 14 years ago

Milestone changed from NULL to 1.0.3

dzuelke commented 14 years ago

(In 7cc70c0d9f500cdf48d062b3fdc7f052eb5d882d) Refactor exception rendering and fix an issue where a stack trace may result in invalid XHTML; closes #1242 and #1240 and refs #1009

dzuelke commented 14 years ago

Issue closed

dzuelke commented 14 years ago

(In 509f035a33d3f5ee647ecf0402857662208746ae) Fix #1284: Regression: Invalid XHTML in shiny exception template when first line in stack frame is HTML. Adds test for this and other issues. Also refs #1009, #1240 and #1242