agb32 / dasp

DASP the Durham Adaptive optics Simulation Platform: Modelling and simulation of adaptive optics systems
https://www.dur.ac.uk/cfai/adaptiveoptics/dasp/
GNU Affero General Public License v3.0
16 stars 10 forks source link

undefined symbol: mvm, rkf_float #3

Closed joncox123 closed 4 years ago

joncox123 commented 4 years ago

Due to changes in GCC, functions declared 'incline' will not be compiled properly by GCC. With Ubuntu 18.04, for example, I receive the error below. The solution is to add the 'static' keyword before the declaration of all 'inline' functions.

'static' must be added to mvm() and rk_float() in scrnmodule.c, iscrnmodule.c and centmodule.c

python scao.py --iterations=200 Traceback (most recent call last): File "scao.py", line 28, in import science.infScrn File "/home/joncox/git/dasp/science/infScrn.py", line 103, in import cmod.scrn ImportError: /home/joncox/git/dasp/cmod/scrnmodule.so: undefined symbol: mvm

agb32 commented 4 years ago

Thanks - have made the changes.

maximecharriere commented 3 years ago

A static is missing here : https://github.com/agb32/dasp/blob/master/cmod/src/centmodule.c#L973