Feature/glblagctwo 1092

[mavdi]

• [ ]  File: lib/multi-sse.js:L1-129
• <img border=0 src='https://avatars.githubusercontent.com/u/372075?v=3' height=16 width=16'> seems like a request validation middleware, which is nice :). Might be more obvious if you called it requestValidationMiddleware - do you agree that this change increases readability?
• <img border=0 src='https://avatars.githubusercontent.com/u/767675?v=3' height=16 width=16'> sure yeah makes sense, I'll change it
• [ ]  File: lib/multi-sse.js:L1-129
• <img border=0 src='https://avatars.githubusercontent.com/u/372075?v=3' height=16 width=16'> not sure if me as this is a typical convention. I've seen _this & that, but not me. This is partially me wanting to keep things similar, and also me being curious about whether this is a new convention.
• <img border=0 src='https://avatars.githubusercontent.com/u/767675?v=3' height=16 width=16'> No new convention. I normally do it as me but happy to switch to anything we normally use in codebase.
• [ ]  File: lib/multi-sse.js:L1-129
• <img border=0 src='https://avatars.githubusercontent.com/u/372075?v=3' height=16 width=16'> how are errors handled here?
• [ ]  File: lib/multi-sse.js:L1-129
• <img border=0 src='https://avatars.githubusercontent.com/u/372075?v=3' height=16 width=16'> Looks like you'll read continuously and rely on highland to allow pausing - is that correct?
• <img border=0 src='https://avatars.githubusercontent.com/u/767675?v=3' height=16 width=16'> This line will feed the stream if the value we read isn't null, down the line we won't process the next event unless the one at hand is processed and sent through, i.e. when next() is called
• [ ]  File: lib/multi-sse.js:L1-129
• <img border=0 src='https://avatars.githubusercontent.com/u/372075?v=3' height=16 width=16'> Definitely log something here

   

[ssebro]

:shipit: