search

agda / agda-categories

A new Categories library for Agda
https://agda.github.io/agda-categories
MIT License
363 stars 68 forks source link

Update to standard-library 1.7.1 #322

Closed iblech closed 1 year ago

JacquesCarette commented 2 years ago

Apparently it's not that simple?

iblech commented 2 years ago

It is :-) You can test it using:

nix-shell -I nixpkgs=https://github.com/iblech/nixpkgs/archive/patch-agda-stdlib1.7.1.tar.gz -p "agda.withPackages (p: [ p.standard-library p.agda-categories ])"

The CI only fails because it does not yet have stdlib 1.7.1 available, which was only released today.

(This pull request is a dependence of a pull request for NixOS, https://github.com/NixOS/nixpkgs/pull/147061.)

JacquesCarette commented 2 years ago

I saw that 1.7.1 was released just earlier today - I was just under the impression that the CI would grab the latest. If it doesn't, then something else needs adjusted too, so that CI passes.

turion commented 2 years ago

I think you need to bump the STDLIB_VERSION variable in github actions as well: https://github.com/agda/agda-categories/blob/1c027debdb615b4f941f08b81647c9be504a75b2/.github/workflows/ci-ubuntu.yml#L49

Otherwise CI will always pull the specific version 1.7

MatthewDaggitt commented 2 years ago

Just a heads up that upgrading to this release is purely optional. Doesn't change any actual Agda code, only makes the cabal file compatible with GHC 9.2 (hence why it hasn't been announced).

JacquesCarette commented 2 years ago

I wasn't going to upgrade, but I also won't refuse a ready-made PR that makes it all work!

iblech commented 2 years ago

@MatthewDaggitt Thank you for the pointer! I force-pushed to my branch. Let's see what the CI will make of this! :-)

JacquesCarette commented 2 years ago

The CI liked it. I'm still vaguely reluctant. Opinions?

turion commented 2 years ago

My two cents: If you merge it you'd have to bump (and eventually release) the agda-categories version as well, since it will not be compatible with standard-library-1.7 anymore.

MatthewDaggitt commented 2 years ago

Ah, the perils of making our first backwards compatible release. We realise we don't have any mechanism for compatible versioning management :laughing:

iblech commented 2 years ago

Hm... yes indeed. Any thoughts on that? We could also patch agda-categories locally in nixpkgs.

turion commented 2 years ago

I think you should merge and bump agda-categories. Releases are simple to download, so people can stay with 1.7 if that's important to them.

JacquesCarette commented 2 years ago

I'm going to pull in a few more PRs first, and then merge-and-bump.

pthariensflame commented 2 years ago

Is this in process still?

JacquesCarette commented 2 years ago

The PRs that I wanted to pull in are in. I just have not had any time to devote to this in the last few weeks. Looks like the next 2 weeks are also a disaster, but clear up after that. I'd be happy to get a co-maintainer though from the people who have submitted many PRs previously, such as @TOTBWF or @sstucki .

TOTBWF commented 2 years ago

I'd be more than happy to help out!

JacquesCarette commented 2 years ago

I'd be more than happy to help out!

Great - see your email for more.