search

agda / agda-github-syntax-highlighting

Syntax highlighting used on GitHub
MIT License
4 stars 4 forks source link

Unify with `language-agda`? #3

Open rwe opened 3 years ago

rwe commented 3 years ago

The syntax definition here looked very familiar in structure.

I wonder if it would improve highlighting coverage to unify the grammar with the one defined for the Atom plugin here? https://github.com/banacorn/language-agda/blob/039c41072c1de62aaed2c9c47a6a8eae1cbc70b6/grammars/agda.cson

I'm not sure which one is more complete but one or both definitions might benefit.

cc @banacorn

banacorn commented 3 years ago

I stole the TextMate grammar from somewhere years ago but I forgot to document where it came from :( I think it's likely to be less complete than other grammars. It is used as a fallback when the more capable context-free grammar goes wrong.

It'd be nice if we can have a unified TextMate grammar anyway.

guillaumebrunerie commented 3 years ago

For a long time, GitHub’s syntax highlighting came from https://github.com/mokus0/Agda.tmbundle, maybe this is where you took it from, @banacorn ? But it was not being maintained and starting to get out of date, so I created this repository and recreated the grammar essentially from scratch.