search

agda / agda-stdlib

The Agda standard library
https://wiki.portal.chalmers.se/agda/Libraries/StandardLibrary
Other
561 stars 234 forks source link

Added missing v1.7.3 CHANGELOG #2356

Closed MatthewDaggitt closed 2 months ago

MatthewDaggitt commented 2 months ago

Fixes #2291

jamesmckinna commented 2 months ago

I don't feel competent to review, having had all my energies at the time focused on v2.0. It would be good to get approval from eg @andreasabel as one of the drivers for v1.7.3?

Also, as a bug fix for v2.0 (?) should this form part of v2.0.1 in the history?

MatthewDaggitt commented 2 months ago

I mean, it's not that I've reconstructed this. I've literally copied it out of the v1.7.3 tag so I don't think there's anything much to review!

I think the chances of v2.0.1 has pretty much died. It's completely slipped off my TO-DO list and it's now many months afterwards which drastically decreases the utility of any quick bug fix release...

jamesmckinna commented 2 months ago

👍 to the first point... further exposing my ignorance!

As to the second, also fair enough, especially as we continue to find bug/'bug-like' aspects of v2.0 (and earlier releases that we didn't manage to fix in v2.0) such as #2299 , #2302 , #2319 , #2332 , etc.

ob which: is #2253 a bug, and should we fix it?