agda / agda-stdlib

The Agda standard library
https://wiki.portal.chalmers.se/agda/Libraries/StandardLibrary
Other
570 stars 234 forks source link

Release v2.1.1 #2461

Closed JacquesCarette closed 3 days ago

JacquesCarette commented 3 weeks ago

Now that it is finally released, we should make sure we're compatible with it (both to see if v2.1 is, and current development/v2.2 is). If memory serves me correctly, neither are - but we should make sure all appropriate wikis are clear about that!

JacquesCarette commented 3 weeks ago

(I was looking at what labels to add to this, and didn't see anything that fit all that well?)

jamesmckinna commented 3 weeks ago

Now that it is finally released, we should make sure we're compatible with it (both to see if v2.1 is, and current development/v2.2 is). If memory serves me correctly, neither are - but we should make sure all appropriate wikis are clear about that!

Oh no!

At least as far as v2.1 is concerned, it should simply be badged as compatible with v2.6.4.3... but that does put pressure on us to make v2.2 release (!) to be 'eventually compatible' with 2.7? Can we fix this up at release time, or will the CI for new commits on existing PRs expect, in particular --exact-split? This may very well be a major source of breaking... sigh ;-)

But as for my current v2.2 developments, I'm not quite ready to make the 'great leap forward'... yet!

andreasabel commented 3 weeks ago

Could you release 2.1.1 instead with just the minimal fixes over 2.1 for Agda 2.7.0? (Some fixes are on the experimental branch.)

JacquesCarette commented 3 weeks ago

That was implicitly my goal with this issue, i.e. get a 2.1.1 release out if it's needed (and then folding that into 2.2), and indeed experimental is already (partway?) there.

iblech commented 3 weeks ago

I just checked: Just two commits from the experimental branch need to be cherry-picked to tag v2.1 in order to establish compatibility with Agda 2.7.0: 586f56ade1574c83e11f63c4a5139fd24becc95c and c7d65e0c40fb257979316c321a4ae0730c1764c1

MatthewDaggitt commented 3 weeks ago

Yup, I will try get it sorted tomorrow

On Mon, 19 Aug 2024, 21:46 Ingo Blechschmidt, @.***> wrote:

I just checked: Just two commits from the experimental branch need to be cherry-picked to tag v2.1 in order to establish compatibility with Agda 2.7.0: 586f56a https://github.com/agda/agda-stdlib/commit/586f56ade1574c83e11f63c4a5139fd24becc95c and c7d65e0 https://github.com/agda/agda-stdlib/commit/c7d65e0c40fb257979316c321a4ae0730c1764c1

— Reply to this email directly, view it on GitHub https://github.com/agda/agda-stdlib/issues/2461#issuecomment-2296620879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAP26EUQZPQ752JXVTN6IT3ZSHZL3AVCNFSM6AAAAABMUAHTISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGYZDAOBXHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MatthewDaggitt commented 3 weeks ago

Created the first release candidate.

MatthewDaggitt commented 3 weeks ago

Second release candidate created

mechvel commented 3 weeks ago

I try testing lib-2.1.1-rc2 on my large application. I type-checks everything. But I also test compilation examples to executable. And this produces internal error due to a bug in Agda 2.7.0 (see news in the Agda bug tracker). Therefore I cannot reliably test lib-2.1.1-rc2 before this bug in Agda is fixed.

mechvel commented 3 weeks ago

More precisely, it is compiled by a certain sequence of type-check-compile commands and produces "internal error" for another sequence. Most probably this effect does depend on the standard library version.

andreasabel commented 3 weeks ago

@mechvel wrote:

And this produces internal error due to a bug in Agda 2.7.0

This refers to

One would speculate that it is a regression in the .agdai creation. I do not think it is related to the standard library.

jamesmckinna commented 2 weeks ago

Milestone is v2.2.1? Rather than v2.1.1?

JacquesCarette commented 2 weeks ago

I think that's just a typo, I'll see if I can fix it.

MatthewDaggitt commented 1 week ago

I've made the release. @gallais any chance you could generate and upload the website docs? I still can't get it running on my computer :cry:

jamesmckinna commented 1 week ago

@MatthewDaggitt @gallais I've just tried following the release-guide.txt instructions, and had several/many problems, so suggest raising a separate continuous-integration/admin issue? In short order, working with the supplied instructions:

At that point, I bailed...

gallais commented 1 week ago

It should have landed now: https://agda.github.io/agda-stdlib/

jamesmckinna commented 1 week ago

Out of interest, @gallais , were you able to diagnose how/why Matthew and I were having problems as above?

gallais commented 1 week ago

I had similar issues with cabal but I do not dare to suggest a solution as everyone seems to have a different version using a different mechanism to run scripts.

I don't know why the location of the EverythingX.agda files would matter given the command line to generate the html includes all of -i. -idoc -isrc. It could be you had stray files left in the doc/ directory?

I don't know why anything would fall over when you checkout gh-pages.

jamesmckinna commented 1 week ago

Thanks @gallais I may try a fresh clone after merging #2473 ...

jamesmckinna commented 5 days ago

I got myself confused as to whether this issue is closed by #2473 or not...

MatthewDaggitt commented 3 days ago

It was closed by @gallais uploading the release branch :smile: Rebasing master so that it includes the changes from v2.1.1 is not per se part of the release process I think...

MatthewDaggitt commented 3 days ago

Thanks everyone for their work!