search

agda / agda

Agda is a dependently typed programming language / interactive theorem prover.
https://wiki.portal.chalmers.se/agda/pmwiki.php
Other
2.4k stars 339 forks source link

[refactor] __FROM_JUST__ = fromMaybe __IMPOSSIBLE__ #7281

Open omelkonian opened 4 weeks ago

omelkonian commented 4 weeks ago

Good for the eyes; hope it's worth the rebasing overhead.

andreasabel commented 4 weeks ago

I think this goes in the opposite direction of what we have been doing before. We want the reported error line of the __IMPOSSIBLE__ as far on the outside as possible. The further outside you handle an exception, the more context you have for analysing what could have closed it.

omelkonian commented 4 weeks ago

@andreasabel Now fixed the error-location callstack being at the point we want and renamed to __FROM_JUST__ to make it shout.