agda / cubical

An experimental library for Cubical Agda
https://agda.github.io/cubical/Cubical.README.html
Other
447 stars 136 forks source link

Remove `isSet` accessors for algebraic structures? #1034

Closed MatthiasHu closed 1 year ago

MatthiasHu commented 1 year ago

I propose to delete the following lemmas:

isSetGroup
isSetRing
isSetDistLattice
isSetCommAlgebra
isSetLeftModule
isSetField
isSetAlgebra
isSetLattice
isSetCommRing
isSetAbGroup
isSetOrderedCommMonoid
isSetCommMonoid

They seem unnecessary, since all these algebraic structures expose an is-set field through the inheritance mechanism of the Is<Something> records already (as demonstrated in https://github.com/agda/cubical/pull/1033). Also note that some structures are missing, e.g. Monoid.

I would say it is better to directly use is-set everywhere (and I would be willing to implement that change). Are there other opinions on this?

felixwellen commented 1 year ago

I agree. One could be unhappy about "public" use of 'is-set' which is not in line with the naming conventions. I am not though. Especially when thinking of using instance resolution to prove h-levels in the future.

mzeuner commented 1 year ago

I support that change as well, especially given that only some structures have such a lemma.

MatthiasHu commented 1 year ago

Good -- I will do this now.