agda / cubical

An experimental library for Cubical Agda
https://agda.github.io/cubical/Cubical.README.html
Other
450 stars 138 forks source link

Normal form of FreeGroup #1099

Closed marcinjangrzybowski closed 5 months ago

marcinjangrzybowski commented 8 months ago

Everythings work at the moment, I will request review once I will add some comments.

felixwellen commented 8 months ago

Are you aware of the parallel PR: https://github.com/agda/cubical/pull/1093 where I try to improve the reflection code of the ringSolver a bit. Maybe there is a chance to share some code? Something completely different: Do you know if it is substantially harder to write a groupoid-solver instead of a group solver?

marcinjangrzybowski commented 8 months ago

I have groupoid solver in works, it is intended as just slight extension of group solver.

On Wed, Feb 7, 2024, 10:48 AM Felix Cherubini @.***> wrote:

Are you aware of the parallel PR:

1093 https://github.com/agda/cubical/pull/1093

where I try to improve the reflection code of the ringSolver a bit. Maybe there is a chance to share some code? Something completely different: Do you know if it is substantially harder to write a groupoid-solver instead of a group solver?

— Reply to this email directly, view it on GitHub https://github.com/agda/cubical/pull/1099#issuecomment-1931665835, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQZARWILQAC534N7YZO5DLYSNEX3AVCNFSM6AAAAABC3ZQM5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRGY3DKOBTGU . You are receiving this because you authored the thread.Message ID: @.***>

marcinjangrzybowski commented 6 months ago

I removed solvers part, so that PR is only about abstract results

felixwellen commented 6 months ago

I am still working towards a wild cat solver, starting with free wild cats here: #1117 Should we coordinate?

felixwellen commented 6 months ago

I made an issue which we can use to coordinate: #1118

felixwellen commented 5 months ago

Is it ready to merge?

marcinjangrzybowski commented 5 months ago

yes, thanks!