agda / cubical

An experimental library for Cubical Agda
https://agda.github.io/cubical/Cubical.README.html
Other
441 stars 134 forks source link

Make the CommRingSolver work better with concrete rings #1101

Open felixwellen opened 5 months ago

felixwellen commented 5 months ago

As pointed out in the examples for the CommRingSolver, there are problems with using concrete rings, e.g. the integers. This is due to the normalisation of the goal that currently happens before the actual parsing of the ring expressions. To fix the problem, it might be enough to just not normalise the goal and introduce matching for the binary minus ´´´-´´´.