Closed aljungstrom closed 2 years ago
I was looking at it to define the general cohomology ring. It is a bit of a mess to have that in Algebra. Should this be put in a way or another in a reorganise (and rename) ZCohomology folder ?
Btw, I think that the file with 1500 lines could gain clarity from a (small) header explaining why an operation with tensor is needed to compute the cup product and what is done in the file. Yes it is packed in module, but there is 1500 lines...
@mortberg @aljungstrom Before merging, should we look were to put this ? Because, the Eilengerb-MacLane up to G (so this) is in group, but the same stuff for G = Z is in ZCohomology/RingStructure ? If we want to compute G-cohomology were should we do that ?
@mortberg @aljungstrom Before merging, should we look were to put this ? Because, the Eilengerb-MacLane up to G (so this) is in group, but the same stuff for G = Z is in ZCohomology/RingStructure ? If we want to compute G-cohomology were should we do that ?
I'll put this in Homotopy, because Eilenberg-MacLane spaces do have more applications than just cohomology. Then I'll make an Eilenberg-MacLane folder in Cohomology for the corresponding cohomology theory (as opposed to the stuff that's there now)
This PR contains
K(G,n) × K(H,m) → K(G⊗H,n+m)
. This stuff used to be inAlgebra.Group.EilenbergMacLane.CupProduct.agda
but has been moved toAlgebra.Group.EilenbergMacLane.CupProductTensor.agda
. Unfortunately, Github thinks all the code is new, but the relevant lines are (apart from some minor changes): 245-321 and 621-K(G,n) × K(G,m) → K(G,n+m)
the ring laws for a general ring - not necessarily a commutative one (graded commutativity will have to wait a bit). This stuff is now inAlgebra.Group.EilenbergMacLane.CupProduct.agda
. (This will be the relevant stuff for @thomas-lamiaux)