search

agdsn / hades

AG DSN Authentication and Authorization Infrastructure
MIT License
8 stars 3 forks source link

Refresh materialized views concurrently or with timeouts #31

Closed fgrsnau closed 8 years ago

fgrsnau commented 8 years ago

This should fix #14 (but no timeout will be set for freeradius).

We should make sure that the UNIQUE constraints are fulfilled on our foreign database, too.

sebschrader commented 8 years ago

As discussed on the channel, we first need to make sure that we can guarantee uniqueness on the remote side.

sebschrader commented 8 years ago

Please test my work from the concurrent_refresh branch and integrate it in this PR.

sebschrader commented 8 years ago

Can you please reset --hard your (deleted) fix-14 branch of your repository to my concurrent_refresh branch, so that we can reopen this pull request and use my branch to close it?

fgrsnau commented 8 years ago

I have tested the changes yesterday: The unique index radusergroup_membership_idx cannot be created, because some of the rows are not unique.

The problem is that the set of columns for the unique index and the columns for the row_number() calculation in radusergroup differs.

sebschrader commented 8 years ago

I see, my tests didn't use the real data. I'll merge this PR regardless and fix it on master.