Remove custom `IntegerConverter`

agdsn / sipa

The Supreme Information Providing Application

MIT License

13 stars 10 forks source link

Remove custom `IntegerConverter` #438

Open lukasjuhrich opened 2 years ago

lukasjuhrich commented 2 years ago

Werkzeug now supports signed values viasigned=True for its IntegerConverter, so the workaround introduced in ea9bbc25c1ef11f5fa0697f410a250cf887e89aa is unnecessary.

Relevant lines: https://github.com/agdsn/sipa/blob/1d5547b32752a96da1c1c164ec0a61a6eab6fc2e/sipa/base.py#L19-L27 https://github.com/agdsn/sipa/blob/b8d11887ee35288e51924f07a0264514fb7a0afc/sipa/initialization.py#L57

lukasjuhrich commented 2 years ago

It has been introduced to support negative values in query parameters, more specifically, to make an URL like https://agdsn.de/sipa/news/?start=-2&end=-1 work.