search

ageller / Firefly

A WebGL interactive particle viewer
GNU Affero General Public License v3.0
65 stars 13 forks source link

defaultsettings filename mismatch #169

Closed marlena6 closed 1 year ago

marlena6 commented 1 year ago

Just starting out using firefly and recently installed it (within the last ~week). I had an issue trying to import SimpleFireReader and ArrayReader that traced to a capitalized D for DefaultSettings.json and DefaultParticleSettings.json in lines 638 and 642 of firefly/data_reader/settings.py, whereas the corresponding files in firefly/static/js/misc/ start with lowercase d. Changing the capitalization fixed the issue.

agurvich commented 1 year ago

🤦🏻 thank you for catching that...

agurvich commented 1 year ago

I'll update the version on pypi as well!!

agurvich commented 1 year ago

Okay, 3.2.1 should be live here and on Pypi. Cheers!!

marlena6 commented 1 year ago

Great, thank you!