ageller / Firefly

A WebGL interactive particle viewer
GNU Affero General Public License v3.0
64 stars 12 forks source link

add ability to select and download data #174

Open ageller opened 1 year ago

ageller commented 1 year ago

I am working toward creating the ability for a user to select a region of data and either download it or have access to it in Python. Currently there is a branch called data_selection that has the work in progress. Here are the important updates currently enabled:

Once I fix this limit on the amount of data that can be passed via flask, I think this branch can be merged into main. But we should probably discuss if we want to integrate this in any way with passing settings back and forth (which is in the python_data_passing branch). I don't think there's any reason to combine the two, but I may be missing something. It's worth a discussion.

Also note that there is some discussion surrounding this topic in issue #166 (about passing setting to and from firefly via flask).

ageller commented 1 year ago

I fixed the issue with accessing large amounts of data in flask by chunking up the data, and recompiling it in Python before making it available to the user. This also allowed for a nice progress bar. I think this completes the goals of selecting data and retrieving it for the user. @agurvich let's discuss sometime soon and then merge this baby into main!